[Issue-11270] Change ContextClassLoader to NarClassLoader in ProtocolHandler #11276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11270
Motivation
See #11270
Modifications
Change context class loader through
Thread.currentThread().setContextClassLoader(classLoader)
before every protocol handler callback, and change it back to original class loader afterwards.Verifying this change
This change added tests and can be verified as follows:
see new test case in org.apache.pulsar.broker.protocol.ProtocolHandlerWithClassLoaderTest#testClassLoaderSwitcher.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation